[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/2] Remove broken hasWindows function from bootloader.py and its callers



On 05/04/2010 11:35 AM, Hans de Goede wrote:
As pylint rightfully points out the hasWindows function from bootloader.py
is broken, it tries to access bootloaderInfo.dosFilesystems, but
bootloaderInfo refers to the bootloaderInfo class, not the module.

This does not cause any tracebacks because it tries to access
bootloaderInfo.dosFilesystems while iterating over bootloader.images, and
bootloader.images has not been set up at this time (so its an empty dict).

Thus hasWindows() will always return false, as there is no way to
determine hasWindows at this point during the installation (we have not yet
paritioned, so any exsting windows partitions may end up being removed),
this patches fixes things by simply removing the hasWindows function and
fixing up any callers of it.
---

Ack.

Ales


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]