[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 15/22] Check return value 2 we get when cancelling a dialog (#520146).



David Cantrell wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Instead of '2', you should add the correct gtk.RESPONSE_* object. Also, this
patch should be rolled in with the one that introduces
selectNetDevicesDialog()

Yes, it should, I'll squash better patch that I attach to the
proper patch.

Radek
>From 44e476bdf37d7197acf0067b0550d70d8348dccb Mon Sep 17 00:00:00 2001
From: Radek Vykydal <rvykydal redhat com>
Date: Tue, 4 May 2010 15:13:56 +0200
Subject: [PATCH] Fix cancel response ids for network config dialogs.

---
 iw/network_gui.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/iw/network_gui.py b/iw/network_gui.py
index 1ec4d83..baa82ee 100644
--- a/iw/network_gui.py
+++ b/iw/network_gui.py
@@ -132,7 +132,7 @@ def selectNetDevicesDialog(network, select_install_device=True):
 
     rv = {}
     dialog = gtk.Dialog(_("Select network interfaces"))
-    dialog.add_button('gtk-cancel', 2)
+    dialog.add_button('gtk-cancel', gtk.RESPONSE_CANCEL)
     dialog.add_button('gtk-ok', 1)
     dialog.set_position(gtk.WIN_POS_CENTER)
     gui.addFrame(dialog)
@@ -253,7 +253,7 @@ def selectSSIDsDialog(devssids):
 
     rv = {}
     dialog = gtk.Dialog(_("Select APs"))
-    dialog.add_button('gtk-cancel', 2)
+    dialog.add_button('gtk-cancel', gtk.RESPONSE_CANCEL)
     dialog.add_button('gtk-ok', 1)
     dialog.set_position(gtk.WIN_POS_CENTER)
     gui.addFrame(dialog)
-- 
1.6.0.6


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]