[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 03/22] Use IfcfgFile class to back NetworkDevice objects (#520146)



David Cantrell wrote:


On Tue, 27 Apr 2010, Radek Vykydal wrote:


-class NetworkDevice(SimpleConfigFile):
+class NetworkDevice(IfcfgFile):
+
+    def __init__(self, dir, iface, logfile='/tmp/ifcfg.log'):
+        IfcfgFile.__init__(self, dir, iface)
+        self.logfile = logfile
+        if iface.startswith('ctc'):
+            self.info["TYPE"] = "CTC"

Why 'CTC' over 'ctc'? Other system tools expect the NETTYPE variable in the
ifcfg file on s390x to contain 'ctc' or 'lcs' or 'qeth' (possibly other
values), so we should probably keep it lowercase.

I just keep doing what we used to do. I can commit the change
to lowercase as separate patch (assuming it acked by you).

Radek



-    def __init__(self, dev):
-        self.info = { "DEVICE" : dev }
-        if dev.startswith('ctc'):
-            self.info["TYPE"] = "CTC"


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]