[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/4] Read in network settings correctly, as configured by linuxrc.s390



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/03/2010 09:46 PM, David Cantrell wrote:
> This patch fixes some old fallout from the move to NetworkManager.
> Without this patch, loaderData never gets fully populated with the
> network settings from linuxrc.s390.  Some backstory:

[snip]

> +        if (g_strv_length(pair) == 2) {
> +            gchar *val = g_shell_unquote(pair[1], &e);
>  
> -            if (!strncmp(vname, "DNS", 3))
> -                loaderData->dns = strdup(vparm);
> +            if (e != NULL) {
> +                logMessage(WARNING, "error reading %s from %s: %s",
> +                           pair[0], cfgfile, e->message);
> +                g_error_free(e);
> +            }

Wouldn't it be useful to also log pair[1] here so that it is hopefully
clear as to why the unquote failed?

- -- 
Brian C. Lane <bcl redhat com>
Red Hat / Port Orchard, WA
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQEVAwUBS+D+wRF+jBaO/jp/AQKZ6gf/V/5AjDLe/tkjSC2hJOWffzN1Dl3x7Ak1
tyApAaheDySsO7o/lBuoLFz44slIsAu+RNlLtNadLGfNz/FFKwczkqeS8DtNvmM9
P0x6j+y5qJioIwaxdnZzXxPQ2uvr125gJuL8F41/MGWVN0PrLEd57FPtLNnPi88Z
KFhOPjvxN/fuLIjeHM4IroS2prBGV4Z2Fj/zNk+mcb8e6PWSErt6tROVjQ8V+XVx
Sy9du+VWTppOIXtxJOcYX31WP8K8ScmPdwJ68E0Q5vZIgoy7QsTtteNXSd7Sg/5z
MJWGQWmQmqRLiI0MQXnhJ1omFQymoq/q0Z7PoeghvVZAB8fFFBo5Hw==
=/rYr
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]