[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/4] Read in network settings correctly, as configured by linuxrc.s390



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue, 4 May 2010, Brian C. Lane wrote:

On 05/03/2010 09:46 PM, David Cantrell wrote:
This patch fixes some old fallout from the move to NetworkManager.
Without this patch, loaderData never gets fully populated with the
network settings from linuxrc.s390.  Some backstory:

[snip]

+        if (g_strv_length(pair) == 2) {
+            gchar *val = g_shell_unquote(pair[1], &e);

-            if (!strncmp(vname, "DNS", 3))
-                loaderData->dns = strdup(vparm);
+            if (e != NULL) {
+                logMessage(WARNING, "error reading %s from %s: %s",
+                           pair[0], cfgfile, e->message);
+                g_error_free(e);
+            }

Wouldn't it be useful to also log pair[1] here so that it is hopefully
clear as to why the unquote failed?

Yes.  In fact, we might as well just log the whole line that failed.

- -- David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkvhDe0ACgkQ5hsjjIy1VknPKwCgp4YHmIZdXLaF5aO4pXW0Cb7e
bKQAn1TjFJB+8D5BI7N8kWC3hBsOr8x3
=Yddi
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]