[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Don't clear bootloader radio selection on double click (#588771).



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/05/2010 11:22 AM, Chris Lumens wrote:
> The problem here was that ClearDisksWindow._remove_clicked wasn't even getting
> called on double click.  Instead, DeviceSelector._row_activated was getting
> called because it was the first registered signal handler in the chain.  Adding
> a second handler appends to the chain.  It does not remove previously added
> handlers.
> ---
>  iw/DeviceSelector.py |    2 +-
>  iw/cleardisks_gui.py |    1 +
>  2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/iw/DeviceSelector.py b/iw/DeviceSelector.py
> index d55efc4..33a7fe3 100644
> --- a/iw/DeviceSelector.py
> +++ b/iw/DeviceSelector.py
> @@ -156,7 +156,7 @@ class DeviceSelector(DeviceDisplayer):
>  
>          self.view.append_column(col)
>          self.view.set_headers_clickable(True)
> -        self.view.connect("row-activated", self._row_activated, toggledCB, radioButton)
> +        self._activated_id = self.view.connect("row-activated", self._row_activated, toggledCB, radioButton)
>  
>      def _all_clicked(self, button, toggledCB=None, membershipCB=None):
>          # This is called when the Add/Remove all button is checked and does
> diff --git a/iw/cleardisks_gui.py b/iw/cleardisks_gui.py
> index 68e6c2f..0fee708 100644
> --- a/iw/cleardisks_gui.py
> +++ b/iw/cleardisks_gui.py
> @@ -171,6 +171,7 @@ class ClearDisksWindow (InstallWindow):
>  
>          # Also allow moving devices back and forth with double click, enter, etc.
>          self.leftTreeView.connect("row-activated", self._add_clicked)
> +        self.rightTreeView.disconnect(self.rightDS._activated_id)
>          self.rightTreeView.connect("row-activated", self._remove_clicked)
>  
>          # And let the user select multiple devices at a time.

Ack

- -- 
Brian C. Lane <bcl redhat com>
Red Hat / Port Orchard, WA
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQEVAwUBS+HB+BF+jBaO/jp/AQJROwf+M2BFnclbQaI2Tf+QnoDg+o1ovwFDmEHQ
QCDPIixqMsANJsdkWNELfmoxJ6ht7NIW2a2UkRkq2IgVSBTTyf2cIWbfWeyVd0si
bLUpuNIihewYOmIwj6h87HpVoDpmpPVmVH0k8kMUDPVxA+12nWjuKicLqheRf2wY
MWzEE2uQgzTnJ/6+pNH3Sdzq06FevhzD92wXF79ry2neuF/Fp8JSiuwHD9P22xVN
/RKwwz+myZUr1PJBZU5323hP5mX20+2gBrKPhwkcn0hQIiwX7gLNdOtGzsX+vtPO
Wyt5k2VMuGQc6lSeAQNI1kddJ/vQL57ZynYTwSXkvoH6Zqe6ZUKxmQ==
=AjVz
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]