[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 03/22] Use IfcfgFile class to back NetworkDevice objects (#520146)



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue, 4 May 2010, Radek Vykydal wrote:

David Cantrell wrote:


On Tue, 27 Apr 2010, Radek Vykydal wrote:


-class NetworkDevice(SimpleConfigFile):
+class NetworkDevice(IfcfgFile):
+
+    def __init__(self, dir, iface, logfile='/tmp/ifcfg.log'):
+        IfcfgFile.__init__(self, dir, iface)
+        self.logfile = logfile
+        if iface.startswith('ctc'):
+            self.info["TYPE"] = "CTC"

Why 'CTC' over 'ctc'? Other system tools expect the NETTYPE variable in the
ifcfg file on s390x to contain 'ctc' or 'lcs' or 'qeth' (possibly other
values), so we should probably keep it lowercase.

I just keep doing what we used to do. I can commit the change
to lowercase as separate patch (assuming it acked by you).

We were writing CTC to the NETTYPE variable?  That does not seem right.  A
separate patch to make sure the NETTYPE is lowercase would be a good thing, I
think.


Radek



-    def __init__(self, dev):
-        self.info = { "DEVICE" : dev }
-        if dev.startswith('ctc'):
-            self.info["TYPE"] = "CTC"


- -- David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkvi2WcACgkQ5hsjjIy1VkkbnwCgyNtW+nHTeX3Uq7CWSS6YDAPd
+6MAoOAcL9fapd95CCjMe2UJIQtfLSFq
=sLkz
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]