[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 03/22] Use IfcfgFile class to back NetworkDevice objects (#520146)



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thu, 6 May 2010, Steffen Maier wrote:

On 05/06/2010 04:59 PM, David Cantrell wrote:
On Tue, 4 May 2010, Radek Vykydal wrote:
On Tue, 27 Apr 2010, Radek Vykydal wrote:

-class NetworkDevice(SimpleConfigFile):
+class NetworkDevice(IfcfgFile):
+
+    def __init__(self, dir, iface, logfile='/tmp/ifcfg.log'):
+        IfcfgFile.__init__(self, dir, iface)
+        self.logfile = logfile
+        if iface.startswith('ctc'):
+            self.info["TYPE"] = "CTC"

Why 'CTC' over 'ctc'?  Other system tools expect the NETTYPE variable
in the
ifcfg file on s390x to contain 'ctc' or 'lcs' or 'qeth' (possibly other
values), so we should probably keep it lowercase.

I just keep doing what we used to do. I can commit the change
to lowercase as separate patch (assuming it acked by you).

We were writing CTC to the NETTYPE variable?  That does not seem right.  A
separate patch to make sure the NETTYPE is lowercase would be a good
thing, I think.

-    def __init__(self, dev):
-        self.info = { "DEVICE" : dev }
-        if dev.startswith('ctc'):
-            self.info["TYPE"] = "CTC"

Last time, I checked, there are no consumers of what this code fragment
initializes. Linuxrc.s390 sets NETTYPE in the ifcfg file (previously it
used to be loader) and anaconda just copies it over to /mnt/sysimage.
Here it says just TYPE and I have no idea what this was used for.
Looking at the scripts in /etc/sysconfig/network-scripts/ it looks like
there is only "Bridge" or "Tap" for TYPE. s390x network devices use only
NETTYPE (and optionally DEVICETYPE, but that can be derived from NETTYPE
[https://bugzilla.redhat.com/show_bug.cgi?id=507214#c7]).
I guess we can just leave it as is, in order not to risk breaking some
old stuff.

That's probably fine then.  I was still thinking something lurking in
/etc/sysconfig/network-scripts might still use NETTYPE.

- -- David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkvjLfUACgkQ5hsjjIy1VkkfXACcCQLf3g2ruWnMvtdZmVgmS+4g
v1oAn0aB1vrsxvkarwyEy8dkBAelEiPp
=Fpj2
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]