[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 8/8] Do not prepend /dev/disk/by-path in format DASD window



> diff --git a/storage/dasd.py b/storage/dasd.py
> index 6c9241f..96508b7 100644
> --- a/storage/dasd.py
> +++ b/storage/dasd.py
> @@ -108,7 +108,7 @@ class DASD:
>          if intf and askUser:
>              devs = ''
>              for dasd, bypath in self._dasdlist:
> -                devs += "/dev/disk/by-path/%s\n" % (bypath,)
> +                devs += "%s\n" % (bypath,)
>  
>              rc = intf.questionInitializeDASD(c, devs)
>              if rc == 1:
> @@ -147,7 +147,7 @@ class DASD:
>                  pw = intf.progressWindow(title, msg, 100, pulse=True)
>  
>          for dasd, bypath in self._dasdlist:
> -            log.info("Running dasdfmt on /dev/disk/by-path/%s" % (bypath,))
> +            log.info("Running dasdfmt on %s" % (bypath,))
>              arglist = argv + ["/dev/" + dasd]
>  
>              try:

In #6 and #7, you assumed the caller was going to deal with the case
where a device's by-path is None.  Should you perhaps be throwing those
out of self._dasdlist before getting to this point?

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]