[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] bootloader timeout default should be None not 0



On 05/10/2010 01:26 PM, Jesse Keating wrote:
> We compare to None later in booty/x86.py and if it is 0 things like the
> chainloader timeout don't get set right.  Resolves 590661
> ---
>  installclass.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/installclass.py b/installclass.py
> index d87b5bb..2e8fcf6 100644
> --- a/installclass.py
> +++ b/installclass.py
> @@ -53,7 +53,7 @@ class BaseInstallClass(object):
>      pkgstext = ""
>      # default to showing the upgrade option
>      showUpgrade = True
> -    bootloaderTimeoutDefault = 0
> +    bootloaderTimeoutDefault = None
>      bootloaderExtraArgs = ""
>  
>      # list of of (txt, grplist) tuples for task selection screen

Definitely ACK for rawhide.  I don't really think this should is
a reason to slip F13, though.

-- 
        Peter

When in doubt, debug-on-entry the function you least suspect has
anything to do with something.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]