[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [RHEL6-BRANCH] Redirect uncpio errors to syslog (#588671)



On 05/12/2010 09:43 AM, Hans de Goede wrote:
Hi,

We are not using syslog anywhere else in the loader, so I'm not sure
this is the preferred way of handling this.

Regards,

Hans


I think this method is the least evil, because rhel6 still has the log.c module in loader/, not in isys/ and he'd need to introduce isys->loader header dependency.

Alternatively we could have a small module/method in isys that appends the log to the tty device directly (and closes it immediately), but that would just be a dead end rhel6 code. On the other hand, the only other place in isys that does logging is imount.c and that's what it does (but it needs to log to program.log). There's no clear win here.

I say yea to bcl's original patch.

Ales


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]