[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Restructuralization of the sources and data in git repo


I moved all data files to one subdirectory, which has the function of share directory in FHS terminology. The repository is much cleaner this way.

The second patch moves isys to another place, because my first intention was to make it part of pyanaconda package (it depends on pyutil). But during the build tests I figured out, that loader depends on it. Moving the files was the lesser evil in comparison to modifying all the loader sources (we use relative imports of isys header files). The dependency on iutil is then solved by PYTHONPATH in Makefiles and automake rules to move it to proper place after build.

Git format patch makes a monstrose changeset, because patch cannot handle file renames. It looks much better in git history.

Martin Sivák
msivak redhat com
Red Hat Czech
Anaconda team / Brno, CZ

----- "Ales Kozumplik" <akozumpl redhat com> wrote:

> On 05/13/2010 09:00 AM, Martin Sivak wrote:
> > Hi,
> >
> > I have prepared (with David's help) a set of patches that move files
> around and make the repository a bit cleaner and better organized. The
> biggest changes are moving anaconda files to pyanaconda/, binary stuff
> (isys, loader, gptsync) to bin/ and support files to data/.
> >
> > The patched source builds manually (both make all and make dist) and
> in koji. I haven't tested compose.
> >
> > I'm open to suggestions, but this structure helped me a lot during
> my investigation of unittesting approaches.
> >
> > Martin
> >
> > PS: Do not be fooled by moving isys around, first I thought the best
> placement for it should be as part of pyanaconda, but after make I
> quickly changed my mind.
> >
> Hi Martin,
> I have some objections:
> Why do you want to move things like loader/ or ui/ around? Those are 
> fine where they are right now, aren't they? Making the directory 
> structure deeper will just make us type more and work with the repo 
> slower. I suggest you only move the anaconda python files into 
> pyanaconda/ -- won't that be enough?
> The first patch seems to remove and add anaconda to the root again. 
> Maybe it just appears weird because of the diff.
> The second patch is called 'update build stuff' but it actually moves
> files. Or am I reading it wrong?
> In any case---with a change like this please make sure that the
> compose 
> passess and the images are bootable.
> Ales
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]