[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/2 master] Add dialog for wireless config (ssid and wepkey) in stage 1 (#473803)



> diff --git a/loader/net.c b/loader/net.c
> index 19bb8be..efb5b4e 100644
> --- a/loader/net.c
> +++ b/loader/net.c
> @@ -459,6 +459,14 @@ int readNetConfig(char * device, iface_t * iface,
>      opts.ipv6Choice = 0;
>  #endif
>  
> +    if (isWirelessDevice(iface->device) &&
> +        (iface->ssid == NULL || iface->wepkey == NULL)) {
> +        ret = wirelessConfig(device, iface);
> +        if (ret == LOADER_BACK) {
> +            return LOADER_BACK;
> +        }
> +    }
> +
>      /* JKFIXME: we really need a way to override this and be able to change
>       * our network config */
>      if (!FL_ASKNETWORK(flags) &&

I'm a little concerned with this block coming before and outside of the
FL_ASKNETWORK blob as I remember this code being especially tricky in
the past.

I assume you've done a lot of testing by going back and forth between
the network config screen and the screens that surround it?  What about
testing via command line parameter passing and seeing what happens?

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]