[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[PATCH] Do not allow editing of extended partitions (#593754)



Editing extended partitions and setting mountpoints and the like for
them is not a good idea. The only useful edit of extended partitions
would be resizing of pre-existing ones and we don't support that.
---
 iw/partition_gui.py |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/iw/partition_gui.py b/iw/partition_gui.py
index aef98b4..1c028cf 100644
--- a/iw/partition_gui.py
+++ b/iw/partition_gui.py
@@ -1143,8 +1143,11 @@ class PartitionWindow(InstallWindow):
 
     def treeActivateCB(self, *args):
         curr_dev = self.tree.getCurrentDevice()
-        if isinstance(curr_dev, storage.PartitionDevice) \
-                or isinstance(curr_dev, storage.LVMLogicalVolumeDevice) \
+        if isinstance(curr_dev, storage.PartitionDevice) and \
+                not curr_dev.isExtended:
+            self.editCB()
+
+        elif isinstance(curr_dev, storage.LVMLogicalVolumeDevice) \
                 or isinstance(curr_dev, storage.LVMVolumeGroupDevice) \
                 or isinstance(curr_dev, storage.MDRaidArrayDevice):
             self.editCB()
@@ -1240,7 +1243,8 @@ class PartitionWindow(InstallWindow):
             self.stripeGraph.setDisplayed(device.parents[0])
             self.stripeGraph.selectSliceFromObj(device)
             self.deleteButton.set_sensitive(True)
-            self.editButton.set_sensitive(True)
+            if not device.isExtended:
+                self.editButton.set_sensitive(True)
 
         elif isinstance(device, storage.LVMVolumeGroupDevice):
             if not isinstance(self.stripeGraph, LVMStripeGraph):
-- 
1.7.0.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]