[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] clearer error messages for missing iscsi initiator name



>  storage/iscsi.py |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/storage/iscsi.py b/storage/iscsi.py
> index 48ccb42..d7a31e7 100644
> --- a/storage/iscsi.py
> +++ b/storage/iscsi.py
> @@ -132,9 +132,9 @@ class iscsi(object):
>  
>      def _setInitiator(self, val):
>          if self.initiatorSet and val != self._initiator:
> -            raise ValueError, "Unable to change iSCSI initiator name once set"
> +            raise ValueError, _("Unable to change iSCSI initiator name once set")
>          if len(val) == 0:
> -            raise ValueError, "Must provide a non-zero length string"
> +            raise ValueError, _("Must provide an iSCSI initiator name")
>          self._initiator = val
>  
>      initiator = property(_getInitiator, _setInitiator)

Do these messages get displayed in a UI, or is there a way for them to
possibly make it into the top-level exception handler.  If the former,
ACK.  If the latter, there's the possibility one day for us to get a
bug filed where the traceback has "Must provide an iSCSI initiator name"
in Korean.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]