[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 3/7] Remove mkdirChain() from isys, use g_mkdir_with_parents()



Ack,

just one comment:

On 11/02/2010 09:44 PM, David Cantrell wrote:
+    if (g_mkdir_with_parents(file, 0755) == -1)
+        logMessage(ERROR, "mkdir error on %s: %m", file);
+
+    if (g_mkdir_with_parents(DD_MODULES, 0755) == -1)
+        logMessage(ERROR, "mkdir error on %s: %m", DD_MODULES);

Maybe we should have a function to call instead of g_mkdir_with_parents that would both call g_mkdir_with_parents() and then do the logging. Would save us some lines and ifs.

Ales


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]