[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [master 2/2] timezones: fix a scrolling problem with the scdate's GUI TreeView.



We discussed the idle method together, so Ack from me.

--
Martin Sivák
msivak redhat com
Red Hat Czech
Anaconda team / Brno, CZ

----- "Ales Kozumplik" <akozumpl redhat com> wrote:

> Without the patch 'New York' is correctly selected upon entering the
> screen but the tree view is scrolled one position below (so the
> highlight
> is not visible at all).
> ---
>  pyanaconda/iw/timezone_gui.py |   11 ++++++++---
>  1 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/pyanaconda/iw/timezone_gui.py
> b/pyanaconda/iw/timezone_gui.py
> index 2d3e4bb..39037ae 100644
> --- a/pyanaconda/iw/timezone_gui.py
> +++ b/pyanaconda/iw/timezone_gui.py
> @@ -39,7 +39,7 @@ class TimezoneWindow(InstallWindow):
>          # this won't work.
>          gtk.glade.set_custom_handler(self.custom_widget_handler)
>  
> -        # Set the default now.  We'll fix it for real in getScreen.
> +        # Set the default now.  We'll fix it for real in upon the
> first render.
>          self.default = "America/New York"
>  
>          self.zonetab = zonetab.ZoneTab()
> @@ -90,8 +90,6 @@ class TimezoneWindow(InstallWindow):
>  
>          self.default = self.default.replace("_", " ")
>  
> -        # Now fix the default we set when we made the timezone map
> widget.
> -        self.tz.setCurrent(self.zonetab.findEntryByTZ(self.default))
>          self.utcCheckbox.set_active(asUTC)
>  
>          if not anaconda.ksdata:
> @@ -99,3 +97,10 @@ class TimezoneWindow(InstallWindow):
>  
>          self.notebook.remove(self.vbox)
>          return self.vbox
> +
> +    def renderCallback(self):
> +        # Now fix the default we set when we made the timezone map
> widget. Due
> +        # to a GTK weirdness, this would not do what we desire if put
> in
> +        # getScreen(): the element would get selected but stay
> outside of the
> +        # visible part of the TreeView.
> +        self.tz.setCurrent(self.zonetab.findEntryByTZ(self.default))
> -- 
> 1.7.1.1
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]