[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 3/4] Show the total amount of space used by snapshots in the VG editor dialog.



On Mon, 2010-11-15 at 11:57 -0500, Chris Lumens wrote:
> > @@ -1372,6 +1381,24 @@ class VolumeGroupEditor:
> >  	maintable.set_row_spacing(row, 0)
> >          row = row + 1
> >  
> > +        maintable.attach(createAlignedLabel(_("Snapshot Total:")),
> > +                         0, 1, row, row + 1, gtk.EXPAND|gtk.FILL, gtk.SHRINK)
> > +        lbox = gtk.HBox()
> > +        self.snapshotSpaceLabel = gtk.Label("")
> > +        labelalign = gtk.Alignment()
> > +        labelalign.set(1.0, 0.5, 0.0, 0.0)
> > +        labelalign.add(self.snapshotSpaceLabel)
> > +        lbox.pack_start(labelalign, False, False)
> > +        self.snapshotPercentLabel = gtk.Label("")
> > +        labelalign = gtk.Alignment()
> > +        labelalign.set(1.0, 0.5, 0.0, 0.0)
> > +        labelalign.add(self.snapshotPercentLabel)
> > +        lbox.pack_start(labelalign, False, False, padding=10)
> > +
> > +        maintable.attach(lbox, 1, 2, row, row + 1, gtk.EXPAND|gtk.FILL, gtk.SHRINK)
> > +        maintable.set_row_spacing(row, 0)
> > +        row = row + 1
> > +
> >          maintable.attach(createAlignedLabel(_("Free Space:")), 0, 1, row,
> >  			 row + 1, gtk.EXPAND|gtk.FILL, gtk.SHRINK)
> >  	lbox = gtk.HBox()
> 
> Perhaps we should just hide the snapshot label if there's no space taken
> up by snapshots?

Good idea. Will send updated version shortly.

Dave

> 
> - Chris
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]