[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 1/3] Add fbpanel panel and NetworkManager applet.



On 11/16/2010 09:12 AM, Ales Kozumplik wrote:
Hi,

On 11/15/2010 01:33 PM, Radek Vykydal wrote:
---
anaconda | 87 ++++++++++++++++++++++++++++++++++++++++++++++++++
  scripts/upd-instroot |    6 +++-
  2 files changed, 92 insertions(+), 1 deletions(-)

diff --git a/anaconda b/anaconda

I don't know if the user experience with the panel is good or not in general (but looks intuitive enough to me), but I think all of this code be better off living in gui.py (perhaps introduce a new method hook in InstallInterfaceBase that starts anything that is necessary before the interface itself shows up).


Agreed, I even had a version of the patch residing in gui.py.
If only I could remember why I didn't use it :/


+        buf = """
+Global {
+    edge = top
+    allign = center
+    margin = 0
+    widthtype = percent
+    width = 100
+    height = 24
+    transparent = true
+    tintcolor = #ffffff
+    alpha = 28
+    setdocktype = true
+    setpartialstrut = true
+    autohide = false
+    heightWhenHidden = 2
+    roundcorners = false
+    layer = none
+}
+
+Plugin {
+    expand = true
+    type = space
+    config {
+        size = 10
+    }
+}
+
+Plugin {
+    type = tray
+}
+
+Plugin {
+#    expand = true
+    type = space
+    config {
+        size = 10
+    }
+}
+
+"""
+        fd = open("/usr/share/fbpanel/anaconda", "w")

Are you going to move this to image generation?

This is not in my plans as I haven't found any arguments for it (yet). Do you have any?
It is more comfortable to have it in code where updates.img can be used for
development/debugging/testing (no need to create/hack image).

Radek


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]