[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 1/2] Improve CheckList class.



On 11/16/2010 07:30 PM, Chris Lumens wrote:


You don't want to use a list as a default in an argument list like this,
or you will be entering a world of pain.  It's better to have
columns=None, and then in your function do something like this:

if not columns:
    columns = ['']

I think it's a little odd to change what "columns" means throughout the
code, though.  In some places, you have it referring to a list of column
titles and in other places, to the number of columns.  It'd be a little
more straightforward to replace the latter usage with ncolumns or the
like.

- Chris


Hi Chris,

Thanks for the comments. I've taken over this bug (I believe it is 641910) and the patch after Tomas has left the team, will post updated patches later.

Ales


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]