[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [rhel6-branch 1/2] iscsi: partial offload drivers.



Hi,

On 11/29/2010 07:51 PM, Brian C. Lane wrote:
On Mon, Nov 29, 2010 at 03:37:56PM +0100, Ales Kozumplik wrote:
+
+def find_program_in_path(prog, raise_on_error=False):
+    for d in os.environ["PATH"].split(":"):

os.pathsep is the portable way to get ':'

I stole the function from master. I agree that os.pathsep() and os.path.join() are a better solution, but I prefer having the branches same even more.

+ISCSI_MODULES=['cxgb3i', 'bnx2i', 'be2iscsi']
+
  def find_iscsi_files():
      global ISCSID
      if ISCSID == "":
@@ -193,6 +195,15 @@ class iscsi(object):
                  os.makedirs(fulldir, 0755)


And a couple more spaces.

I can't see what spaces you mean. Are you talking about newline after ISCSI_MODULES or is your email client messing things up? In the web archive it looks as I intended, or are there problems still?
https://www.redhat.com/archives/anaconda-devel-list/2010-November/msg00257.html

Ales


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]