[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [rhel6-branch 1/2] iscsi: partial offload drivers.



> > +        full = "%s/%s" % (d, prog)
> 
> I'd use os.path.join() to make sure there aren't any ugly // in the path

Gotta be careful with os.path.join, though:

commit 9fb8b3c594fda5b6fcebbae18cbbf7aae4255fd7
Author: Chris Lumens <clumens redhat com>
Date:   Thu Mar 27 15:52:32 2008 -0400

    os.path.join does not work the way we think it should.
    
    "If any component is an absolute path, all previous components are thrown
    away, and joining continues."
    
    -- http://docs.python.org/lib/module-os.path.html

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]