[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [rhel6-branch 1/2] iscsi: partial offload drivers.



On Tue, 2010-11-30 at 10:23 -0500, Chris Lumens wrote:
> > > +        full = "%s/%s" % (d, prog)
> > 
> > I'd use os.path.join() to make sure there aren't any ugly // in the path
> 
> Gotta be careful with os.path.join, though:
> 
> commit 9fb8b3c594fda5b6fcebbae18cbbf7aae4255fd7
> Author: Chris Lumens <clumens redhat com>
> Date:   Thu Mar 27 15:52:32 2008 -0400
> 
>     os.path.join does not work the way we think it should.
>     
>     "If any component is an absolute path, all previous components are thrown
>     away, and joining continues."
>     
>     -- http://docs.python.org/lib/module-os.path.html
> 
> - Chris
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

that's exactly why I stopped using it too, got almost my whole
workstation wiped out, when I was testing the removing of files in lorax
installtree...

-- 
Martin Gracik <mgracik redhat com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]