[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [rhel6-branch 1/2] iscsi: partial offload drivers.



On Tue, Nov 30, 2010 at 09:50:20AM +0100, Ales Kozumplik wrote:
> Hi,
> 
> On 11/29/2010 07:51 PM, Brian C. Lane wrote:
> >On Mon, Nov 29, 2010 at 03:37:56PM +0100, Ales Kozumplik wrote:
> >>+
> >>+def find_program_in_path(prog, raise_on_error=False):
> >>+    for d in os.environ["PATH"].split(":"):
> >
> >os.pathsep is the portable way to get ':'
> 
> I stole the function from master. I agree that os.pathsep() and
> os.path.join() are a better solution, but I prefer having the
> branches same even more.

I say fix them both ;)

> 
> >>+ISCSI_MODULES=['cxgb3i', 'bnx2i', 'be2iscsi']
> >>+
> >>  def find_iscsi_files():
> >>      global ISCSID
> >>      if ISCSID == "":
> >>@@ -193,6 +195,15 @@ class iscsi(object):
> >>                  os.makedirs(fulldir, 0755)
> >>
> >
> >And a couple more spaces.
> 
> I can't see what spaces you mean. Are you talking about newline
> after ISCSI_MODULES or is your email client messing things up? In
> the web archive it looks as I intended, or are there problems still?
> https://www.redhat.com/archives/anaconda-devel-list/2010-November/msg00257.html

Sometimes I forget that most people's editors don't show extra
whitespaces. The first one had about 8, the other two had 2 spaces all
on lines with no following content.

Here's the vim config (from dcantrell) to show tabs as ___| and spaces
as a gray . if you're interested.

" Hilight tabs and trailing spaces
set list listchars=tab:\|_,trail:.
highlight SpecialKey ctermfg=DarkGray


-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Attachment: pgpAAdC9DHwJd.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]