[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH rhel6-branch] network: using more than one NICs (iSCSI) (#638131, #634016)

> - In rhel 5.6 we apply the kickstart configuration of first network command,
>   other network commands only set configuration for post install reboot.
> - In rhel 6.0 all network commands only set configuration that is applied
>   only after reboot.
>   (There is one issue that devices having ONBOOT=yes set will be brought
>   up before package installation, when network configuration is written
>   into ifcfg files. This might cause routing problems, though none has been
>   reported yet. It is to be handled in separate bug.)
> - With the patchset, network commands concerning already activated device
>   only set post-install configuration - the device is not reconfigured in
>   installer - same as in 6.0. Other devices having new --activate option
>   are brought up in loader. (The ONBOOT=yes issue remains as in 6.0)
> Do we want to change it back to the 5.6? I'm not against it but I think it
> would be better to do it in a separate bug.

I don't think we intentionally meant to change the behavior from RHEL 5
to RHEL6.  At least, I don't remember us discussing that.  However, much
of this networking stuff is very subtle so it's entirely possible it got
changed without us ever knowing.

This concept of the first network command in particular being somehow
magic is especially frustrating.  Do we document that behavior anywhere,
or is this just how things have always worked?

With that said, I think reverting back to RHEL 5 behavior is the right
thing to do.

> I noticed that the patchset is changing behaviour from 5.6 and 6.0
> in the case
> when network is not brought up before parsing ks. In 5.6 and 6.0
> we would bring network up using first network command, whereas with
> this patchset, it would be so only if --activate is present in the first
> command. I will fix this so that if network is not up, --activate flag
> (lack of it) is ignored and the device is activated.

I really like the clarity of the --activate option, personally.  I'd be
all for us defining the future of the network command as so:

* Any network commands given without --activate will refer just to
  post-installation configuration.

* Any network commands given with --activate will refer both to
  install-time configuration as well as post-installation.

I think that should be flexible enough to cover all cases.
Unfortunately, getting us in position to do the above in RHEL is
difficult given that we have to have a transition period.  We can't just
switch it over, especially not for 6.1.

Also, I can't stress enough how we need to thoroughly document this.

- Chris

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]