[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [rhel6-branch] ppc: do not allow creating a second PReP partition on one drive.



> diff --git a/storage/partitioning.py b/storage/partitioning.py
> index 06c078b..048539a 100644
> --- a/storage/partitioning.py
> +++ b/storage/partitioning.py
> @@ -94,9 +94,17 @@ def _schedulePartitions(anaconda, disks):
>  
>          if request.fstype is None:
>              request.fstype = anaconda.id.storage.defaultFSType
> -        elif request.fstype == "prepboot" and anaconda.platform.bootDevice():
> -            # there should never be a need for more than one PReP partition
> -            continue
> +        elif request.fstype == "prepboot":
> +            # make sure there never is more than one prepboot per disk
> +            bootdev = anaconda.platform.bootDevice()
> +            if (bootdev and
> +                anaconda.id.bootloader.drivelist and
> +                anaconda.id.bootloader.drivelist[0] == bootdev.disk.name):
> +                # do not allow creating the new PReP boot on the same drive
> +                log.info("partitioning: skipping a PReP boot "
> +                         "partition request on %s" % bootdev.disk.name)
> +                continue
> +            log.debug("partitioning: allowing a PReP boot partition request")
>  
>          # This is a little unfortunate but let the backend dictate the rootfstype
>          # so that things like live installs can do the right thing

Looks okay to me.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]