[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 1/2] Make sure devices ignored by the devicetree are in _ignoredDisks.



On Fri, 2011-01-14 at 10:11 -0500, Chris Lumens wrote:
> > diff --git a/pyanaconda/storage/devicetree.py b/pyanaconda/storage/devicetree.py
> > index f6bfa5c..42ae164 100644
> > --- a/pyanaconda/storage/devicetree.py
> > +++ b/pyanaconda/storage/devicetree.py
> > @@ -879,6 +879,9 @@ class DeviceTree(object):
> >  
> >          if self.isIgnored(info):
> >              log.debug("ignoring %s (%s)" % (name, sysfs_path))
> > +            if name not in self._ignoredDisks:
> > +                self.addIgnoredDisk(name)
> > +
> >              if udev_device_is_multipath_member(info):
> >                  # last time we are seeing this mpath member is now, so make sure
> >                  # LVM ignores its partitions too else a duplicate VG name could
> 
> Are self._ignoredDisks and the set of things ignored by self.isIgnored
> always identical?

Not necessarily, no. That's why this is needed -- otherwise we have no
way to tell what was ignored after deciding to ignore it.

Dave



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]