[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Reduce code duplication in storage.devices.



On Thu, Jan 13, 2011 at 10:28:39AM -0600, David Lehman wrote:
>  devices.py |  940 +++++++++++++++++++------------------------------------------
>  1 file changed, 308 insertions(+), 632 deletions(-)
> 
> This patch set, especially #4, removes a bunch of code duplication in
> the Device classes' setup/teardown/create/destroy methods.
> 
> The only part I'm not totally happy with is the UI stuff. I like the
> idea, but it seems less than elegant. Ideas for improvement are welcome.

I know I'm late to the party ;) But is there a reason not to use
docstrings for long comments explaining what is going on? At some point
it would be nice if running doxygen on the code would generate useful
docs.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Attachment: pgpTfWQvVOktj.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]