[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] use pykickstart for loader kickstart processing



On Thu, 20 Jan 2011, Chris Lumens wrote:

As previously promised, here's my patches to use pykickstart inside loader.  I
have tested the kickstart.c parts by adding a separate patch that allows
building a standalone executable (can merge as well if anyone cares), but not
of the patch set as a whole.

These fix bug 667526, though that was not my main motivation here.

Ack to them all, with the comment that the code that creates C-bindings
for pykickstart should maybe be part of pykickstart rather than loader.
That may or may not be possible, but if any of the functions of generic
enough to warrant a libpykickstart as part of the pykickstart package, I
think that would be better for maintenance in the future.

All in all, I like the patch set.  It's nice to eliminate another
pykickstart parser.

--
David Cantrell <dcantrell redhat com>
Supervisor, Installer Engineering Team
Red Hat, Inc. | Honolulu, HI | UTC-10


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]