[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Disable partition resize support for DASD labels (#605912)



On Wed, 2011-01-26 at 12:28 -1000, David Cantrell wrote:
> This just doesn't work and I have no idea when it will work in the
> future, so we should just prevent users from trying this.  Such a narrow
> use case.

It would be nicer IMO to implement PartitionDevice.resizable such that
it does this new check and also checks super(StorageDevice,
self).resizable. This would remove the need to check hasattr(self,
"disk").

Dave

> ---
>  storage/devices.py |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/storage/devices.py b/storage/devices.py
> index 61082be..9695470 100644
> --- a/storage/devices.py
> +++ b/storage/devices.py
> @@ -590,6 +590,9 @@ class StorageDevice(Device):
>      @property
>      def resizable(self):
>          """ Can this type of device be resized? """
> +        if hasattr(self, "disk") and self.disk and self.disk.type == 'dasd':
> +            return False
> +
>          return self._resizable and self.exists and \
>                 ((self.format and self.format.resizable) or not self.format)
>  



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]