[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Disable partition resize support for DASD labels (#605912)



On Wed, 2011-01-26 at 17:41 -0500, Chris Lumens wrote:
> > diff --git a/storage/devices.py b/storage/devices.py
> > index 61082be..9695470 100644
> > --- a/storage/devices.py
> > +++ b/storage/devices.py
> > @@ -590,6 +590,9 @@ class StorageDevice(Device):
> >      @property
> >      def resizable(self):
> >          """ Can this type of device be resized? """
> > +        if hasattr(self, "disk") and self.disk and self.disk.type == 'dasd':
> > +            return False
> > +
> >          return self._resizable and self.exists and \
> >                 ((self.format and self.format.resizable) or not self.format)
> 
> Couldn't you instead add:
> 
>    @property
>    def resizable(self):
>       return False
> 
> to the definition of DASDDevice?

That won't do what needs doing since StorageDevice.resizable (inherited
by PartitionDevice) doesn't (and shouldn't) check the parents' resizable
attribute.

Dave

> 
> - Chris
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]