[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [booty rhel5-branch] Fix cutting of the partiotion 'p' in getDiskPart().



On 05/16/2011 04:01 PM, Chris Lumens wrote:
Before it worked OK for 'mapper/mpath1p2' but it failed to separate the
partition part from 'mapper/rootdevp1' (because the disk part contains no
digits)

This replaces the ancient part of the method with something simpler and
hopefully more general (though it's hard to say it doesn't brake some
other cases).

The nice thing about this function is that it's completely standalone,
so it should be possible for you to whip up a pile of test cases and
verify that it works for old devices as well as for the things in this
bug.


I took the function out of the file and ran a couple of tests (mpath1, mpath12p3, rootdev, etc.). Unfortunately I am not sure how to check those in without including the mock machinery we have on rawhide. So this has to do for now.

Ales


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]