[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[PATCH pyblock] Don't build with -Werror



This -Werror has caused
https://bugzilla.redhat.com/show_bug.cgi?id=715663

and some confusion at
https://bugzilla.redhat.com/show_bug.cgi?id=709161
because the equivalent F15 update build failed.

In general it doesn't seem like a good idea to bail out on warnings
as future versions of gcc will have a different idea of what should
be warned about.

On the other hand, this build failure actually found a real bug, so
I may not be making a convincing case here. Thoughts?
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 3b8eb7b..d059ed1 100644
--- a/Makefile
+++ b/Makefile
@@ -5,7 +5,7 @@ DEBUGSRC := "/usr/src/debug"
 DEBUGLIB := "/usr/lib/debug"
 CC := gcc
 PYVER := $(shell python -c "import sys; print sys.version[0:3]")
-CFLAGS := -g -I/usr/include/python$(PYVER) -Wall -Werror -fPIC $(OPTFLAGS) -fno-strict-aliasing
+CFLAGS := -g -I/usr/include/python$(PYVER) -Wall -fPIC $(OPTFLAGS) -fno-strict-aliasing
 LDFLAGS := -shared
 
 VERSION := $(shell awk '/Version:/ { print $$2 }' python-pyblock.spec)
-- 
1.7.6.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]