[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/2] Replace the last layout instead of removing (KeyboardSpoke)



On Tue, 2012-01-31 at 11:56 -0500, Chris Lumens wrote:
> > @@ -165,6 +169,9 @@ class KeyboardSpoke(NormalSpoke):
> >                  if item in dialog.chosen_layouts:
> >                      duplicates.add(item)
> >                  itr = self._store.iter_next(itr)
> > +            if self._remove_last_attempt:
> > +                self._store.remove(self._store.get_iter_first())
> > +                self._remove_last_attempt = False
> >              for layout in dialog.chosen_layouts:
> >                  if layout not in duplicates:
> >                      self._addLayout(self._store, layout)
> 
> Please add some blank lines between blocks.
ok

> 
> > @@ -181,8 +188,12 @@ class KeyboardSpoke(NormalSpoke):
> >              itr2 = store.iter_next(itr2)
> >              if itr2: #next one existing
> >                  selection.select_iter(itr2)
> > -            #nothing left to be selected
> > -            store.remove(itr)
> > +                store.remove(itr)
> > +                return
> > +            #nothing left, run AddLayout dialog to replace the current layout
> > +            self._remove_last_attempt = True
> > +            add_button = self.builder.get_object("addLayoutButton")
> > +            GLib.idle_add(self.on_add_clicked, add_button)
> >              return
> >  
> 
> Why is the idle_add call necessary?
It is probably not necessary. I just wanted to make sure the UI redraws
correctly before invoking AddLayout dialog and it's lightbox. Should I
remove it?

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]