[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] fix serial console option parsing (#767745)



On Wed, Feb 01, 2012 at 01:54:21PM -0500, Will Woods wrote:
> Anaconda was expecting serial console options with only the baud rate
> after the comma, for example:
>   console=ttyS0,115200
> 
> But this is also valid (see Documentation/kernel-parameters.txt):
>   console=ttyS0,115200n8
> 
> So this patch adds a function to parse the options correctly, and improves
> the GRUB serial_command() method to use the parsed options wherever they
> vary from the default values.
> 
> Based on a patch by Jan Stancek <jstancek redhat com> - thanks!
> ---
[snip]

> @@ -1111,18 +1144,24 @@ class GRUB(BootLoader):
>  
>      @property
>      def serial_command(self):
> -        command = ""
> +        command = ["serial"]
>          if self.console and self.console.startswith("ttyS"):

[snip]

> +        return " ".join(command)

This is going to return "serial" even when self.console is false. Is
that desired? It doesn't match the previous behavior of returning "".


-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Attachment: pgphDK2qbDcT5.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]