[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Add 'traceback' boot option for python-meh and libreport testing



On Wed, 2012-02-15 at 10:39 -0500, Chris Lumens wrote:
> > diff --git a/pyanaconda/iw/filter_type.py b/pyanaconda/iw/filter_type.py
> > index a26a02c..e562dea 100644
> > --- a/pyanaconda/iw/filter_type.py
> > +++ b/pyanaconda/iw/filter_type.py
> > @@ -30,6 +30,8 @@ from iw_gui import *
> >  from pyanaconda.flags import flags
> >  from pyanaconda.storage.deviceaction import *
> >  
> > +from pyanaconda.flags import flags
This import is redundant, I'll push the patch without it.

> >  import gettext
> >  _ = lambda x: gettext.ldgettext("anaconda", x)
> >  
> > @@ -39,6 +41,10 @@ class FilterTypeWindow(InstallWindow):
> >          ics.setTitle("Filter Type")
> >          ics.setNextEnabled(True)
> >  
> > +        if flags.cmdline.getbool("traceback"):
> > +            ics.getICW().anaconda.intf.enableNetwork()
> > +            raise RuntimeError("Intentionally raised exception")
> > +
> >      def getNext(self):
> >          if self.buttonGroup.getCurrent() == "simple":
> >              self.anaconda.simpleFilter = True
> 
> For the current UI, it looks okay.  Are they going to want this same
> functionality in text mode?  There's no filter type screen there.
I've asked kparal and he said they don't have a test case for this in
text mode now. But we should not forget to have something like that in
both (all) NewUI modes.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]