[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 5/5] Limit the swap size when fill all available space is selected



On Fri, 2012-02-17 at 14:34 +0100, Vratislav Podzimek wrote:
> Resolves: rhbz#744129

This is one of the things where we swing back and forth every time
someone files a bug. I am 99.9% positive we have changed stances on this
matter at least once in the past. Let's be certain we reach a consensus
on the correct behavior instead of assuming that someone complaining
about it makes it a real bug.

User A: I had 5TB left on my disk and I made a swap partition with "grow
to maximum allowable size" and I got a 5TB swap partition! This is bad!
Fix it!

User B: I had 1GB RAM and had 2.2GB left on my disk and, wishing to
create a swap partition to consume the remainder of my free space, I
created a swap partition and marked it as "grow to maximum allowable
size". Now I see that I have ~200MB of wasted space. I told the
installer to use the rest of the space, so why did it not do that? How
annoying.

My opinion, given only the preceding scenarios, is that User A is
suffering from operator error, while User B has a valid complaint. This
patch will make us betray competent User B in favor of placating
misguided User A.

Dave

> ---
>  iw/partition_dialog_gui.py |    9 ++++++---
>  1 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/iw/partition_dialog_gui.py b/iw/partition_dialog_gui.py
> index 2bf053a..cbd365c 100644
> --- a/iw/partition_dialog_gui.py
> +++ b/iw/partition_dialog_gui.py
> @@ -93,7 +93,7 @@ class PartitionEditor:
>  
>  	frame.add(sizeoptiontable)
>  
> -	return (frame, fixedrb, fillmaxszrb, fillmaxszsb)
> +	return (frame, fixedrb, fillmaxszrb, fillmaxszsb, fillunlimrb)
>  
> 
>      def run(self):
> @@ -163,6 +163,9 @@ class PartitionEditor:
>                  else:
>                      maxsize = 0
>  
> +                if self.fillunlimrb.get_active() and (fmt_class._type == "swap"):
> +                    maxsize = SWAP_SIZE_LIMIT
> +
>                  allowdrives = []
>                  model = self.driveview.get_model()
>                  iter = model.get_iter_first()
> @@ -526,8 +529,8 @@ class PartitionEditor:
>          # size options
>          if not self.origrequest.exists:
>              (sizeframe, self.fixedrb, self.fillmaxszrb,
> -             self.fillmaxszsb) = self.createSizeOptionsFrame(self.origrequest,
> -                                                        self.fillmaxszCB)
> +             self.fillmaxszsb, self.fillunlimrb) = self.createSizeOptionsFrame(
> +                                                        self.origrequest, self.fillmaxszCB)
>              self.sizespin.connect("value-changed", self.sizespinchangedCB,
>                                    self.fillmaxszsb)
>  



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]