[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] add the foundations for the add repository dialog



Hi Brian,

you can review the glade by applying the patch and then running

make runspoke SPOKE_MODULE=software

in previously compiled tree.

That is probably the only way of checking the GUI stuff.

Martin

----- Original Message -----
> On Mon, Jun 11, 2012 at 03:10:44PM +0200, Martin Sivak wrote:
> > +from pyanaconda.ui.gui.utils import enlightbox
> > +from .source import AdditionalReposDialog
> 
> I like the relative import, we should do more of this.
> 
> So far this looks pretty good to me, with just some minor things:
> 
> > -from gi.repository import AnacondaWidgets, GLib, Gtk
> > +from gi.repository import AnacondaWidgets, GLib, Gtk
> 
> space added to the end here.
> 
> > +    typingTimeout = 1
> > +
> > +    def __init__(self, *args, **kwargs):
> 
> Added 4 spaces instead of blank line.
> 
> There are a couple more of these, I won't point them all out.
> 
> > +    def on_list_title_clicked(self, w, d):
> > +        print "click1"
> > +        self._sourceSelectionList.set_active(True)
> > +
> > +    def on_url_title_clicked(self, w, d):
> > +        print "click2"
> 
> Extra debug prints
> 
> > +        self._sourceSelectionUrl.set_active(True)
> > +
> > +    def on_url_timeout(self, w):
> > +        # start resolve thread with epoch info
> > +
> > +        self._repositorySpinner.start()
> > +        self._repositoryDesc.set_text("Getting info about
> > requested repository")
> 
> This should be translated, may as well start now so we don't forget.
> 
> I'm not sure if there is any reasonable way to review the glade
> changes.
> 
> I'd also like to see more use of docstrings and comments. The newui
> code
> is like learning Anaconda all over again and I have a hard time
> keeping
> track of everything.
> 
> --
> Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA
> (PST8PDT)
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]