[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/2] Use ksdata.timezone and timezone module instead of anaconda.timezone



On Mon, 2012-06-18 at 11:17 -0400, Chris Lumens wrote:
> > +    try:
> > +        with open(os.path.normpath(root + "/etc/sysconfig/clock"), "w") as file_:
> 
> Maybe I'm just being too picky, but there's something about a name with
> a trailing underscore that just makes me cringe.
It is what PEP 8 says about names conflicting with Python keywords [1],
but I can of course use something else.

Do these patches look good otherwise?

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]