[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH f17-branch 2/2] dracut/parse-kickstart: handle network --device=link (or none)



> > > +        line.append("ip=%s:dhcp" % dev if dev else "ip=dhcp")

Someone's been looking at too much perl.

I know other people have written similar constructions in their patches
in the past, and we've always asked them to take it out.

> I did actually test this code before sending it for review - I try to
> test everything I send, or clearly mark it as untested otherwise. I
> assume that's what everyone does? Do we need to codify that or anything?

We don't really have any rules about it.  Certainly, everyone ought to
test what they write before they send it and especially for release
branches.  Master is of course a little less important.  I'll admit I've
sent off stuff untested before, or at least not tested thoroughly
enough.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]