[augeas-devel] Re: [PATCH] Dhclient lens

[Free Ekanayaka]

Hi David,

|--==> On Wed, 27 Aug 2008 22:39:01 +0000, David Lutterkort <lutter at redhat.com> said:

  DL> On Wed, 2008-08-27 at 22:22 +0200, Free Ekanayaka wrote:
  >># HG changeset patch
  >># User Free Ekanayaka <free at 64studio.com>
  >># Date 1219868519 -7200
  >># Node ID 715e29b93bc86728fdb541a59cfa48d42fdd52d1
  >># Parent  cff4cb60ca2b80ae886db42376dd2fc9877b67b3
  >>Dhclient lens

  DL> Nice. Committed after fixing one minor nit spotted by the brandnew
  DL> typecheck of del:

  >>diff -r cff4cb60ca2b -r 715e29b93bc8 lenses/dhclient.aug
  >>--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
  >>+++ b/lenses/dhclient.aug	Wed Aug 27 22:21:59 2008 +0200

  >>+let sep_obr           = del /[ \t\n]*\{\n]*/" \{\n"
  >>+let sep_cbr           = del /[ \t\n]*\}/ " \}"

  DL> The string defaults for these need to be " {\n" and " }" ... seems
  DL> there's a bug[1] in the lexer when processing escape sequences. For now,
  DL> it's easiest to sidestep the bug ;)

Ah, ok :) I've changed it in my local hg repository, I'm going to mail
the patch for sake of completenes. Thanks.

Free