[augeas-devel] Re: [PATCH] Allow spaces in entry values

[David Lutterkort]

On Sat, 2008-07-26 at 12:28 +0200, Raphaël Pinson wrote:
> 
> 
> On Fri, Jul 25, 2008 at 8:43 PM, David Lutterkort <dlutter at redhat.com>
> wrote:
>         On Fri, 2008-07-25 at 13:45 +0200, raphink at gmail.com wrote:
>         > # HG changeset patch
>         > # User Raphael Pinson <raphink at gmail.com>
>         > # Date 1216986332 -7200
>         > # Node ID 1b45132a77ca0062db7c401ef110d280de16888b
>         > # Parent  86411abff2eec6aa4364b7d3f43fe2e94e3ab31c
>         > Allow spaces in entry values
>         >
>         > diff -r 86411abff2ee -r 1b45132a77ca lenses/inifile.aug
>         > --- a/lenses/inifile.aug      Fri Jul 25 13:22:27 2008 +0200
>         > +++ b/lenses/inifile.aug      Fri Jul 25 13:45:32 2008 +0200
>         > @@ -11,7 +11,7 @@ module IniFile  =
>         >      let value_sep          = del /[ \t]*=/ " = "
>         >      let value_sepwithcolon = del /[ \t]*(=|:)/ " = "
>         >      let value_to_eol       = del /[ \t]*/ " " . store /([^
>         \t\n].*[^ \t\n]|[^ \t\n])/
>         > -    let value_to_comment   = del /[ \t]*/ "" . store /[^;#
>         \t\n]+/
>         > +    let value_to_comment   = del /[ \t]*/ " " . store /[^;#
>         \t\n][^;#\n]*[^;# \t\n]|[^;# \t\n]/
>         
>         
>         Is the change of default for del intentional ?
> 
> It is, but it is wrong indeed. Actually, since I was managing the
> spaces before the values in value_sep(withcolon)? before, then I
> should also change the default for value_sep(withcolon)? to " ="
> instead of " = ".
> 
> Or do you think that the default for INI files should be without
> spaces at all?

That seems a matter of taste ... I would leave the spaces out by
default, but either probably works.

David