[augeas-devel] [PATCH 1 of 6] Fix containment check

[David Lutterkort]

# HG changeset patch
# User David Lutterkort <dlutter at redhat.com>
# Date 1210036162 25200
# Node ID 65fb6042de243d0274bc776ab1e43881f044f3fb
# Parent  12a89085ff03b0188284da610cadf29ca1b7d5ac
Fix containment check

Checking for FA2\FA1 being empty was plain silly; this check is a little
better, but still not the correct disjointness check.

diff -r 12a89085ff03 -r 65fb6042de24 src/lens.c
--- a/src/lens.c	Fri May 02 11:01:50 2008 -0700
+++ b/src/lens.c	Mon May 05 18:09:22 2008 -0700
@@ -284,12 +284,10 @@ static struct value *useless_union(struc
               "internal error: compile in useless_union failed");
     }
 
-    fa_t minus = fa_minus(fa2, fa1);
-    if (fa_is_basic(minus, FA_EMPTY)) {
+    if (fa_contains(fa2, fa1)) {
         exn = make_exn_value(ref(info),
              "%s: the first lens completely shadows the second lens", msg);
     }
-    fa_free(minus);
     fa_free(fa1);
     fa_free(fa2);
     return exn;