[augeas-devel] Re: [libvirt] PATCH: Add a augeas lens for libvirtd.conf

[Daniel P. Berrange]

On Wed, Sep 03, 2008 at 10:40:45PM +0200, Daniel Veillard wrote:
> On Wed, Aug 27, 2008 at 12:04:17PM +0100, Richard W.M. Jones wrote:
> > On Tue, Aug 26, 2008 at 09:05:37PM +0100, Daniel P. Berrange wrote:
> > > Augeas is a awesome config file manipulation tool. libvirtd has a config
> > > file. libvirtd meet augeas; augeas meet libvirt.
> > > 
> > > Now instead of telling people 
> > > 
> > >   'edit /etc/libvirt/libvirtd.conf and change listen_tls to 1,
> > >    and auth_tls to sasl'
> > > 
> > > we can say run
> > > 
> > >    # augtool <<EOF
> > >    set /files/etc/libvirt/libvirtd.conf/listen_tls 1
> > >    set /files/etc/libvirt/libvirtd.conf/auth_tls sasl
> > >    save
> > >    EOF
> > >    
> > > THis patch is intended to be committed to libvirt, so the config file rules
> > > are distributed alongside libvirt. I'm CC'ing augeas-devel for feedback on
> > > the lens itself.
> > > 
> > >  libvirt.spec.in         |    2 
> > >  qemud/Makefile.am       |    8 
> > >  qemud/libvirtd.aug      |   64 ++++++
> > >  qemud/test_libvirtd.aug |  484 ++++++++++++++++++++++++++++++++++++++++++++++++
> > >  4 files changed, 558 insertions(+)
> > 
> > +1, to the general concept, and the code apart from the lens itself
> > which I didn't look at too closely.
> 
>   Same thing, I like the idea and if David agrees with the .aug files
> and changes then I guess this should be commited,

Thanks, I've committed this now.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|