[augeas-devel] Need help with logrotate lens enhancement

Sean E. Millichamp sean at bruenor.org
Mon Sep 29 20:03:04 UTC 2008


On Sun, 2008-09-28 at 20:12 +0200, Raphaël Pinson wrote:

> Thanks for the patch, it looks very nice. I based the initial lens on
> the options I usually use, so I'm not surprised it's lacking fields.
> However, list_to_eol is not used as of now. I think it would be
> actually better to use it instead of defining tabooext separately. So
> you would have 

I apologize if I sounded like I was complaining that there were missing
fields - I appreciate not having had to start from scratch on it!

I suppose I could rework it to work that way, but tabooext is the only
configuration option that has the special behavior of the leading "+"
option.  Also, list_to_eol is currently used in the patch by the
compressoptions option.

> It would also be nice to try and limit lines to 80 (or preferably 75)
> characters and begin to document the code (with NaturalDocs, I might
> begin to do that for all lenses when I get some time).

I just tried to follow the style that was already in the file.  I didn't
see any coding styles documented and there were a number of lines
already longer then 80 characters.

I spent more time then I really had available to finish the
functionality and I don't have any more right now to go back and figure
out enough of what the lens is doing in all the parts to document the
entire lens properly.  I am not opposed to tackling it eventually, but
it isn't anywhere on my radar right now.

Regards,
Sean






More information about the augeas-devel mailing list