[augeas-devel] Patch for Samba.aug

Partha Aji paji at redhat.com
Tue Dec 8 19:31:51 UTC 2009


http://www.samba.org/samba/docs/man/manpages-3/smb.conf.5.html
"""
FILE FORMAT

 The file consists of sections and parameters. A section begins with the name of the section in square brackets and continues until the next section begins. Sections contain parameters of the form:
name = value
.....
"""

No mention of : anywhere. Don't think samba likes ":" for separator. 

Partha

----- Original Message -----
From: "David Lutterkort" <lutter at redhat.com>
To: "Partha Aji" <paji at redhat.com>
Cc: "augeas-devel" <augeas-devel at redhat.com>
Sent: Monday, December 7, 2009 12:49:36 PM GMT -05:00 US/Canada Eastern
Subject: Re: [augeas-devel] Patch for Samba.aug

On Fri, 2009-12-04 at 15:20 -0500, Partha Aji wrote:
> The samba augeas lens had issues dealing with entry key names that had ':' in them like,
> 		recycle:repository = .recycle
> 		recycle:keeptree = yes
> 		recycle:versions = yes
> 
> The attached patch fixes this issue. 


> diff --git a/lenses/samba.aug b/lenses/samba.aug
> index 4b303f6..28b9cf1 100644
> --- a/lenses/samba.aug
> +++ b/lenses/samba.aug
> @@ -14,7 +14,7 @@ module Samba =
>   *************************************************************************)
>  
>  let comment  = IniFile.comment IniFile.comment_re IniFile.comment_default
> -let sep      = del /[ \t]*[=:]/ " ="
> +let sep      = del /[ \t]*[=]/ " ="
>  let indent   = del /[ \t]*/ "   "

Why the change to sep ? Can ':' be used for the same purpose as '=' ?

David





More information about the augeas-devel mailing list