[augeas-devel] [PATCH] Add Httpd lens

[Francis Giraldeau]

On Tue, 2011-01-25 at 18:11 -0800, David Lutterkort wrote:
> On Sun, 2011-01-23 at 01:32 -0500, Francis Giraldeau wrote:
> > The Httpd lens parses Apache Web server configuration according to the manual.
> > 
> >   * Generic sections with square lens
> >   * Generic directives
> >   * Arguments of sections and directives are handled as list
> > 
> > The lens doesn't support automatic quoting of string values, because arguments
> > are separated by spaces and it raises ambiguity when using unquoting. The lens
> > doesn't support either long lines splitted by backslash.
> 
> ACK. Comments:
> 
> > diff --git a/lenses/httpd.aug b/lenses/httpd.aug
> > new file mode 100644
> > index 0000000..1f4a814
> > --- /dev/null
> > +++ b/lenses/httpd.aug
> > @@ -0,0 +1,89 @@
> > +(* Apache HTTPD lens for Augeas
> > +
> > +Author: Francis Giraldeau <francis.giraldeau at usherbrooke.ca>
> > +
> > +About: Reference
> > +  Online Apache configuration manual: http://httpd.apache.org/docs/trunk/
> > +
> > +About: License
> > +    This file is licensed under the GPL.
> 
> Can we have this as LGPLv2+ like the rest of Augeas ?

Fixed. 

> 
> > +About: Configuration files
> > +  This lens applies to /etc/dhcpd3/dhcpd.conf. See <filter>.
> 
> Cut & paste error ?

Fixed. 

> 
> > +let filter = (incl "/etc/apache2/apache2.conf") .
> > +             (incl "/etc/apache2/httpd.conf") .
> > +             (incl "/etc/apache2/ports.conf") .
> > +             (incl "/etc/apache2/conf.d/*") .
> > +             (incl "/etc/apache2/mods-available/*") .
> > +             (incl "/etc/apache2/sites-available/*") .
> > +             Util.stdexcl
> 
> Can we add /etc/httpd/conf.d/*.conf and /etc/httpd/conf/httpd.conf to
> the filter ? Those are used on RH distros.

Fixed. 

Also added other contributors to authors and included in makefile for
tests.

Francis