[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Cluster-devel] cluster/cmirror-kernel/src dm-cmirror-client.c



CVSROOT:	/cvs/cluster
Module name:	cluster
Branch: 	RHEL4
Changes by:	jbrassow sourceware org	2006-12-05 03:13:51

Modified files:
	cmirror-kernel/src: dm-cmirror-client.c 

Log message:
	Bug 214487: "Attempt to mark a already marked region" messages when ...
	
	When a log server moves (like durring a failure or the mirror being
	shutdown on that node), the clients send the new server the regions
	that they have marked.
	
	However, the clients where sending _all_ of the regions they had
	marked for every mirror that was active - even for the ones whose
	log server had not moved.  This was causing those servers to report
	that they already had those regions marked.
	
	Other than the annoying messages, I don't believe there were any
	side affects of this bug.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/cmirror-kernel/src/dm-cmirror-client.c.diff?cvsroot=cluster&only_with_tag=RHEL4&r1=1.1.2.29&r2=1.1.2.30

--- cluster/cmirror-kernel/src/Attic/dm-cmirror-client.c	2006/11/27 23:15:43	1.1.2.29
+++ cluster/cmirror-kernel/src/Attic/dm-cmirror-client.c	2006/12/05 03:13:50	1.1.2.30
@@ -512,6 +512,9 @@
 
 			DMINFO(" - Resending all mark region requests");
 			list_for_each_entry(rs, &marked_region_list, rs_list){
+				/* Resend only those associated with referenced log */
+				if (rs->rs_lc != lc)
+					continue;
 				do {
 					retry = 0;
 					DMINFO("   - " SECTOR_FORMAT, rs->rs_region);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]