[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Cluster-devel] cluster/gfs2/tool Makefile util.c



> --- cluster/gfs2/tool/util.c	2006/05/05 18:06:09	1.4
> +++ cluster/gfs2/tool/util.c	2006/06/15 16:40:48	1.5
> @@ -27,13 +27,14 @@
>  #include <libgen.h>
>  #include <dirent.h>
>  #include <string.h>
> -#include <asm/page.h>
>  
>  #define __user
>  #include <linux/gfs2_ondisk.h>
>  
>  #include "gfs2_tool.h"
>  
> +#define PAGE_SIZE (4096)
> +
>  static char sysfs_buf[PAGE_SIZE];
>  
>  char *__get_sysfs(char *fsname, char *filename)

I am afraid this change will make portability a problem. Quite a bunch of
architectures have different PAGE_SIZE. Perhaps it's worth to dig on why it
doesn't build on x86_64 instead?

Thanks
Fabio

-- 
I'm going to make him an offer he can't refuse.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]