[Cluster-devel] [GFS2] don't panic needlessly [1/5]

Steven Whitehouse steve at chygwyn.com
Mon Nov 6 11:07:51 UTC 2006


>From eb1dc33aa235b0e44ada6716cda385883c6e6bff Mon Sep 17 00:00:00 2001
From: Alexey Dobriyan <adobriyan at gmail.com>
Date: Sat, 28 Oct 2006 03:03:48 +0400
Subject: [PATCH] [GFS2] don't panic needlessly

First, SLAB_PANIC is unjustified. Second, all error propagating and backing out
is in place.

Signed-off-by: Alexey Dobriyan <adobriyan at gmail.com>
Signed-off-by: Steven Whitehouse <swhiteho at redhat.com>
---
 fs/gfs2/main.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c
index 21508a1..9889c1e 100644
--- a/fs/gfs2/main.c
+++ b/fs/gfs2/main.c
@@ -84,8 +84,8 @@ static int __init init_gfs2_fs(void)
 
 	gfs2_inode_cachep = kmem_cache_create("gfs2_inode",
 					      sizeof(struct gfs2_inode),
-					      0, (SLAB_RECLAIM_ACCOUNT|
-					      SLAB_PANIC|SLAB_MEM_SPREAD),
+					      0,  SLAB_RECLAIM_ACCOUNT|
+					          SLAB_MEM_SPREAD,
 					      gfs2_init_inode_once, NULL);
 	if (!gfs2_inode_cachep)
 		goto fail;
-- 
1.4.1






More information about the Cluster-devel mailing list